Commit Graph

35522 Commits

Author SHA1 Message Date
Thales Lima bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
TreeHugger Robot a33cbebd8d Merge changes from topic "presubmit-am-18a7324d3163401db618e725a06a3dba" into sc-qpr1-dev
* changes:
  [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 3e39786ec3
  Import translations. DO NOT MERGE ANYWHERE
2021-11-18 18:18:41 +00:00
Bill Yi 9dc66c4bd7 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f841aa488d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16291585

Change-Id: I7876bfffdef580a4b3a44e4342915ea7f4b980d7
2021-11-18 18:03:19 +00:00
TreeHugger Robot 160d85c815 Merge "Adding back the badges on widgets for widget recommendations." into sc-v2-dev 2021-11-18 17:44:50 +00:00
TreeHugger Robot f46f911fd1 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-11-18 17:20:21 +00:00
Alex Chau 4670d37e55 Check if ThumbnailData's bitmap is null in TaskThumbnailCache
- This makes sure TaskThumbnailCache fetch for thumbnail when its Bitamp is null

Fix: 206959035
Test: See steps in b/206959035
Change-Id: I03b574b0f8cc7390a8cad618bd810f44f0dee279
2021-11-18 15:57:28 +00:00
Brian Isganitis 49f25681ef Make action optional for snackbar.
Test: Manual
Bug: 188222480
Change-Id: I923dcf50633d8ba751d86095f43e97563a53b692
2021-11-18 10:22:41 -05:00
Thales Lima 45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
TreeHugger Robot 1edee616ae Merge "Move live tile app to top when the task view is tapped" into sc-v2-dev 2021-11-18 12:26:05 +00:00
Alex Chau 60d5315e19 Refresh overlay when thumbnail was set for first time
Bug: 202414125
Test: TaplTestsNexus.testOverviewActions && TaplTestsQuickstep.testOverviewActions
Change-Id: I2cc38df4c891fb21a8295d4f9c75e396c71449f2
2021-11-18 10:31:13 +00:00
Alex Chau 90a9982b36 Merge "Recognizing Launcher builds consisting only of digits" into sc-v2-dev 2021-11-18 09:59:59 +00:00
TreeHugger Robot 5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Bill Yi 645278133c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I96e0a393c618e4bf956a23d2da8066d123f13932
2021-11-18 04:20:51 +00:00
Bill Yi f841aa488d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I15ccd3db00e2a2353337a834b41706dedeac2749
2021-11-18 04:20:12 +00:00
Bill Yi 8aa6d024aa [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 3e39786ec3
Blank merge reason: commit message contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16291580

Change-Id: Ide698cc4f38b744d9126aaa550d68e2f73cb30fc
2021-11-18 04:19:40 +00:00
Bill Yi 3e39786ec3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I88e2ee9b0d5fd68d79eb888f201d649541ea0844
2021-11-18 04:19:33 +00:00
Vinit Nayak be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
Tony Wickham 9ceae57095 Add support for dark tint on taskbar nav buttons
Tint the buttons when taskbar isn't drawing a background (either due to alpha or offset).

Test: Dark icons on a light wallpaper on home screen, dark icons when light IME is showing
Bug: 204256643
Change-Id: Iae634a1b604f50edc102905abd0d812a43c5346e
2021-11-17 16:28:21 -08:00
TreeHugger Robot 010faef3a5 Merge "Add animated background to the suw all set page." into sc-v2-dev 2021-11-18 00:07:35 +00:00
TreeHugger Robot ec2bd55047 Merge "Use TOUCHABLE_INSETS_REGION when IME is visible" into sc-v2-dev 2021-11-17 23:57:56 +00:00
Vinit Nayak c1ec2d4260 Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I79a32541ea9ebae9ad78ad933f55212d0bc64b56
2021-11-17 15:29:42 -08:00
Fedor Kudasov c8f686710e Move FloatingTaskInit set up into init method
This makes the code more tidy and consistent with
other classes. Additionally, this allows for easier
annotation of the initialization code.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: Ib7ecf32cffd5c6af67a4c2095d7cb3e3a2f387e4
(cherry picked from commit f50acd3ed855f21a4aca0d98ef9fc6c1099423d2)
2021-11-17 22:13:43 +00:00
Tony Wickham 49da26f636 Merge changes I36871463,I691a5cbb,I62105c1c into sc-v2-dev
* changes:
  Update reorder and folder creation radii
  Fix misaligned folder creation drag over target
  Update CellLayout.DEBUG_VISUALIZE_OCCUPIED to include drag over targets
2021-11-17 22:08:28 +00:00
Tony Wickham bf4a91b0f1 Use TOUCHABLE_INSETS_REGION when IME is visible
This ensures the dismiss button is fully clickable even if taskbar is stashed.

Test: Stash taskbar, can dismiss keyboard by tapping anywhere on the back button
(Same with taskbar unstashed)
Fixes: 206851484

Change-Id: I06f86191e36b596a928c8db8d67a012be033daba
2021-11-17 14:04:25 -08:00
Tracy Zhou 5163574b7a Move live tile app to top when the task view is tapped
- transition animation for foldables need it

Bug: 205789573
Test: manual
Change-Id: Icf11d204968dbffa6bb9c930deaa57d35e2eff4a
2021-11-17 13:59:49 -08:00
Sebastian Franco 0a1328d9fb Adding back the badges on widgets for widget recommendations.
Test: Manual Testing
Fix: 202956924
Change-Id: I859d3d93d95bdc8d0742eb6b5dd40ad12a386928
2021-11-17 15:08:09 -06:00
Alex Chau 7c9055fc6b Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev 2021-11-17 21:02:16 +00:00
Schneider Victor-tulias 92c6ae64de Add TODO to fix b/206508141 before removing or changing the default value to the feature flag ENABLE_LOCAL_COLOR_POPUPS
Bug: 206508141
Test: None
Change-Id: I8a8290f1e7d24c9fd2e8922f0126fa3d713e10a4
2021-11-17 12:22:02 -08:00
Tracy Zhou a37f8baa1d Merge "Refine when to move live tile app below recents view" into sc-v2-dev 2021-11-17 19:53:14 +00:00
Winson Chung 0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
vadimt 60ba2ac084 Recognizing Launcher builds consisting only of digits
Bug: 206687633
Test: online regex tools
Change-Id: Ia6155f22fb9a0eba3beb6edb607f44f901629330
2021-11-17 19:07:20 +00:00
Fedor Kudasov e65c47e60f Merge "Add some more @Nullable annotations" into sc-v2-dev 2021-11-17 18:42:53 +00:00
TreeHugger Robot 42f111dc27 Merge "Revert "Add feature flag to control two panel home in portrait"" into sc-v2-dev 2021-11-17 17:47:16 +00:00
Winson Chung 9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Jonathan Miranda ae1bcc9ba8 Revert "Adding screen record for a flake"
This reverts commit da02250c29.

Reason for revert: Flake resolved
Bug: 202735477
Test: presubmit

Change-Id: I86856110ca9b8745c194a716a587d3bbe7f0137e
2021-11-17 16:24:26 +00:00
Alex Chau 9012582ef7 Revert "Add feature flag to control two panel home in portrait"
This reverts commit b1c36ce938.

Reason for revert: experiment no longer requried
Bug: 197723099

Change-Id: I585fa4364ab5326a19b099a80a1a02a66370d84f
2021-11-17 14:16:58 +00:00
Fedor Kudasov 3256e1e744 Add some more @Nullable annotations
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
(cherry picked from commit 9385170c1b3b295c8d087cbc1de761f25aadc1ba)
2021-11-17 08:40:17 +00:00
Tracy Zhou a4edc07ec8 Refine when to move live tile app below recents view
- We will still need to figure out why, but currently the overview scrim blocks the cut out during transition. To go around this, we need to move live tile app after the overview transition animation is over
- Some of the logic in RecentsView is no longer necessary since we are no longer reusing live tile params and simulator, but assign new targets each time

Fixes: 205587164
Test: manual
Change-Id: Icadf26182112bba544a4103b626effa37d4028b5
2021-11-16 21:17:19 -08:00
TreeHugger Robot b797ca77b2 Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev 2021-11-16 21:34:52 +00:00
Sebastian Franco 3b86202a95 Fling to close tasks in the GestureNav can be too small.
The problem is that the velocity threshold to activate the fling
was set using pixels per second, so a better aproach would is to
use dp/s. So now there is a variable set in the dimes.xml file
called base_swift_detector_fling_release_velocity.

Test: Manually tested
Fix: 201252634
Change-Id: Ief14f25de136dead74f03cb24d2120b67900239e
2021-11-16 14:46:36 -06:00
TreeHugger Robot 36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
Tracy Zhou 1fdea66f16 Fix memory leak in TaskbarLauncherStateController
mIconAlphaForHome.setConsumer(null) in onDestroy()

Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
TreeHugger Robot 82fc85f9b8 Merge "Fix LauncherProvider newScreenId issue" into sc-v2-dev 2021-11-16 19:00:47 +00:00
Alex Chau 04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau 1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
TreeHugger Robot d8a1b5c366 Merge "Fix overview scroll triggering haptics on swipe up gesture" into sc-v2-dev 2021-11-16 16:48:14 +00:00
Alex Chau b7abf7e96d Fix launch animation from bottom row and end of grid
- Apply gridTranslationY when calculating taskRect so it's used to calculate RecnetsView pivot
- Moved recentsViewScroll to RecentsView group and applied after recentsViewScale
- Before: http://dr/file/d/1-Nrqa80J4FRbjcdZ3GZSeKwfQF8fN9a1/view?resourcekey=0-gYT9z1HA0YksW5Ujbzsmeg
- After: http://dr/file/d/1-DpZrg5_nFeUKS-8APnLvG8SJVvke9BU/view?resourcekey=0-p59hm-abzpU7Y7tqWyneTQ

Fix: 200813202
Test: Launch task from grid from top/bottom/left/right/focus
Test: Launch task from left/middle/right in small screen
Change-Id: I814512c02611f59a5a6d1f53411d42cf4f0f26b3
2021-11-16 13:55:38 +00:00
TreeHugger Robot a6c4b66b7f Merge "Revert "Add ScreenRecord to methods affected by a flaky problem"" into sc-v2-dev 2021-11-16 13:03:33 +00:00
Alex Chau 033f2afe38 Revert "Add ScreenRecord to methods affected by a flaky problem"
This reverts commit ea6ee1c824.

Reason for revert: Seems to increase the severity of the flaky problem
Bug: 204807156

Change-Id: I7b87f2abf45c9da21981f9361e320163bd7834bd
2021-11-16 11:19:09 +00:00
Fedor Kudasov 72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00