clitest.py used the value 100000000000 (100 PB) for memory size, which
was parsed as 0 by older libvirt. Latest release (1.2.10) has the
parsing fixed and properly reports an error on overflow. Changing the
memory size to 4000000 (4 TB) is still an overcommit, at least most
development machines and it works properly.
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This patches adds the support to check the thread # against the
selected CPU model. If the selected # of CPU threads > 1 and CPU
model does not support hyper-threading, a warning message will be shown.
Signed-off-by: Wei Huang <wei@redhat.com>
Not all CPUs support Hyper-Threading. This patch adds a warning
message next to the threads selection field of processor topology
box. It warns that "Selected CPU model does not support
Hyper-Threading" when # of Threads > 1 and the selected CPU model
does not support Hyper-Threading.
This UI modification was added using glade 3.18.3.
Signed-off-by: Wei Huang <wei@redhat.com>
shortkey M for fs-mode in fsdetail duplicate shortkey of
"Virtual Machine" in details.
change it to 'o'.
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
of named "folder" icon. That seems a good fit, a quick check on my system finds
it present in all themes that are available.
virt-manager uses some icons included in the gnome-icon-theme package.
Make it explicit and add a dependency.
Desktop folks agree that this is the place where to add this
dependency as adding it to gtk is too problematic.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146612
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
(1) A separate nvram (ie. variable store) file for the domain exists if
and only if the following condition holds:
(self.get_xmlobj().os.loader_ro is True and
self.get_xmlobj().os.loader_type == "pflash")
(Refer to libvirtd's qemuPrepareNVRAM() function, as of commit 742b08e30.)
(2) The
self.get_xmlobj().os.nvram
condition is sufficient, but not necessary, for the separate varstore file
to exist. That is, if the condition holds, then the separate varstore file
exists for sure, but if the condition doesn't hold, the file may exist
nonetheless. (Because libvirtd can auto-generate the varstore file's
pathname.)
This means that requiring condition (2) for setting UNDEFINE_NVRAM on
domain deletion will miss a subset of the cases, ie. when the necessary
and sufficient condition (1) holds, but the sufficient-only condition (2)
doesn't.
Make sure that the code uses the necessary and sufficient condition (1).
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Chen Hanxiao