Commit Graph

3964 Commits

Author SHA1 Message Date
Chen Hanxiao cff8e32c55 virt-install: support setting hugepages/page/[@size, @unit, @nodeset] for memorybacking
libvirt commit
136ad49740f017aabcac48d02d2df6ab7b0195e9
introduce ./hugepages/page/[@size, @unit, @nodeset]
for memory backing.
This patch will add support in virt-install.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-07-30 14:34:03 +08:00
Giuseppe Scrivano 92de2db42b virtManager: always save "do not show again" setting
Any other message box performs different than "Unapplied changes",
which stores this information regardless of the user choice of
Yes/No.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047874

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:17 +02:00
Giuseppe Scrivano 4ba378d1b0 virtManager, host: warn user for unapplied changes
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1047875

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 19:19:16 +02:00
Chen Hanxiao 5f3ede96de storage: fix a typo
s/paramaters/parameters

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-07-28 16:55:28 +08:00
Giuseppe Scrivano 148576d69e virtinst, clone: use the specified MAC address for the new VM
Prevent setup_clone from changing the self._clone_macs list so that
further calls will access the same data.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1027576

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-28 10:38:31 +02:00
Giuseppe Scrivano 312b349fce virt-manager, create: honor untoggled "Set a fixed MAC address"
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1083461

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-22 09:25:05 +02:00
Jakub Steiner 76fff97a5e add proper toolbar icon size
https://bugzilla.redhat.com/show_bug.cgi?id=1117763
2014-07-18 11:07:28 -04:00
Cole Robinson 5f81c4bdc0 virtinst: cli: Tweak some command line strings and indentation 2014-07-15 09:25:20 -04:00
Roman Bogorodskiy 613d933d31 setup: drop obsolete virtconv/parsers data_files
Commit 0b4a72f dropped virtconv/parsers/ files, so remove
them from data_files list in setup.py as well.
2014-07-12 16:08:08 -04:00
Cole Robinson 8ea634f9e4 guest: Enable Hyper-v Enlightenments for Windows VMs
These are the recommended defaults for all windows VMs, when using
a new enough libvirt + kvm. Some more details in this boxes bug report:

https://bugzilla.gnome.org/show_bug.cgi?id=732811
2014-07-07 18:24:40 -04:00
Giuseppe Scrivano cbb18b0e96 network: refresh the XML definition on state update
The XML definition returned by libvirt can change on a state
transition. vmmNetwork.force_update_status invalidates the old
definition.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-08 00:05:09 +02:00
Giuseppe Scrivano e44ee980ae virtManager: add QoS information for a network
Add UI elements to display and modify QoS settings in the network
details.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-08 00:05:09 +02:00
Cole Robinson 9986074ab0 connection: Revive option to show QEMU/KVM in pretty desc
I thought it was unused, but it was just grep fail
2014-07-07 18:00:10 -04:00
Tal Kain 02e2fd9cd4 vmmCreate: Fixed an AttributeError created by 7fcdd61
When trying to create a new virtual machine an exception has been thrown:
Error launching manager: 'vmmConnection' object has no attribute
'get_pretty_desc_active'

Signed-off-by: Tal Kain <tal@kain.net>
2014-07-07 17:54:19 -04:00
Giuseppe Scrivano 0deff29ee7 virtManager, create: set the model for autocompletion earlier
it fixes this error:

(virt-manager:11676): Gtk-CRITICAL **: gtk_tree_model_get_iter_first: assertion 'GTK_IS_TREE_MODEL (tree_model)' failed

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Giuseppe Scrivano 6e7c406b6a virtManager, create: prevent focus on widget when not visible
it fixes this error:

(virt-manager:11184): Gtk-WARNING **: GtkEntry - did not receive focus-out-event. If you connect a handler to this signal, it must return FALSE so the entry gets the event as well.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-05 12:00:49 +02:00
Cole Robinson 7fcdd61920 manager: Expand logic to avoid colliding connection descriptions
And drop some unused code
2014-07-04 18:20:54 -04:00
Cole Robinson aa823b5b58 connection: Handle unsupport KeepAlive (like test URIs) 2014-07-04 18:20:54 -04:00
Cole Robinson e12d7a6a8c connection: Report error if things fall over during connection bring up 2014-07-04 18:20:54 -04:00
Cole Robinson f66c4ef3e4 connection: Fix error reporting if TCP creds dialog fails 2014-07-04 18:20:54 -04:00
Cole Robinson 1e77c05c4e Clarify some translation strings, reported on transifex 2014-07-04 16:42:24 -04:00
Giuseppe Scrivano 32b9653f5b virt-manager: select the initial connection
Automatically select the connection in this order:

- URI specified via command line --connect
- First active connection
- First connection

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:41 +02:00
Giuseppe Scrivano f4365b669a console: prevent access to deleted objects
last commits revealed that some objects can still be accessed by
registered callbacks after the console is closed.  Unregister these
callbacks.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:41 +02:00
Giuseppe Scrivano 538c68a41d virt-manager: check if still connected every 20 seconds
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:40 +02:00
Giuseppe Scrivano 3606bb573d virtinst: add method to set connection keep-alive
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-07-02 15:31:40 +02:00
Cole Robinson 3c2dc15af7 serialcon: Remove some redundant VTE API calls
Latest VTE doesn't seem to provide set_emulation anymore, and the other
two seem to be the default anyways. This also avoids some VTE bindings
breakage on current rawhide:

https://bugzilla.redhat.com/show_bug.cgi?id=1114379
2014-07-02 09:20:17 -04:00
Ron ea1d973957 Don't create disk images world readable and executable
Python's os.open() defaults to mode 0777 if not explicitly specified.
Disk image files don't need to be executable, and having them world
readable isn't an ideal situation either.  Owner writable and group
readable is probably more than sufficient when initially creating
them.

Signed-off-by: Ron Lee <ron@debian.org>
2014-07-02 07:35:15 +02:00
Chen Hanxiao ddd88dac25 storage: fix another comment typo
s/explictly/explicitly

Thanks for Giuseppe's reminding.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-30 16:20:38 +08:00
Chen Hanxiao 7ce434fed7 urlfetcher: fix a comment typo
s/Explictly/Explicitly

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-30 10:58:53 +08:00
Chen Hanxiao 658c9500a9 createnet: fix a small pylint
commit f109b1ed6f
used a undefined variable 'PAGE_MAX'.
It looks like it should be in a developing series,
but should be fixed in upstream.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 09:06:14 +02:00
Chen Hanxiao 240111f091 create: fix a comment typo
s/detction/detection

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-27 10:06:24 +08:00
Giuseppe Scrivano f109b1ed6f createnet: validate last page before creating the network
On the last page in the createnet wizard the Next button is changed to
Finish.  Ensure the user input is validated also on this page.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Giuseppe Scrivano 81bd6bbffb createnet: fix "show_err" typo
s|show_erro|show_err|

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Giuseppe Scrivano 57d26e6265 virtinst: parse "bandwith" node in network definition
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-26 15:26:37 +02:00
Cole Robinson 72d0d5d8ea manager: Make it clear which functions are called from engine.py 2014-06-26 09:05:34 -04:00
Cole Robinson f6e214d438 testdriver: Add network <bandwidth> example 2014-06-26 08:50:08 -04:00
Giuseppe Scrivano eb5b261311 details.py: fix typo
s|removeable|removable|

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1112629

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Giuseppe Scrivano 48be09a997 createnet: use vmmInterface.get_name() instead of vmmInterface.name
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/host.py", line 467, in add_network
    self.addnet.show(self.topwin)
  File "virt-manager/virtManager/createnet.py", line 102, in show
    self.reset_state()
  File "virt-manager/virtManager/createnet.py", line 180, in reset_state
    devnames.append(iface.name)
AttributeError: 'vmmInterface' object has no attribute 'name'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-24 17:14:19 +02:00
Cole Robinson c78974c0d9 connection: Drop netdev abstraction
Just open code it in the one place it's needed. Try to simplify some of
the netlist logic while we are at it. Should fix:

https://bugzilla.redhat.com/show_bug.cgi?id=1109574
2014-06-18 12:41:36 -04:00
Giuseppe Scrivano 4ac49a1d66 virt-manager: split EDIT_VCPUS and EDIT_MAXVCPUS
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1098040

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-17 17:27:47 +02:00
Chen Hanxiao 27d03b8b92 preferences ui: fix a duplicate shortkey
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 13:21:46 +08:00
Chen Hanxiao 75d43f6a37 fix some missed binary prefixes for units
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:33:14 +08:00
Chen Hanxiao 100023baa6 preferences ui: add shortkey for Add Spice USB Redirection
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-17 09:32:42 +08:00
Giuseppe Scrivano 5c2459e6e4 createpool.py: fix creation of gluster pools
It fixes this exception:

Traceback (most recent call last):
  File "virt-manager/virtManager/createpool.py", line 454, in page_changed
    self.set_page(page_number)
  File "virt-manager/virtManager/createpool.py", line 451, in set_page
    self.show_options_by_pool()
  File "virt-manager/virtManager/createpool.py", line 292, in show_options_by_pool
    self.widget("pool-source-name").get_child().set_text(
AttributeError: 'Entry' object has no attribute 'get_child'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2014-06-16 08:20:58 +02:00
Chen Hanxiao 2f4a424521 use binary prefixes for units where appropriate
https://bugzilla.redhat.com/show_bug.cgi?id=1103893

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:56:53 +08:00
Chen Hanxiao ba96af8df8 addhardware: add a tool tip when USB controller already existed
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:50:04 +08:00
Chen Hanxiao e124f3e401 addhardware: enable setting model when adding controller
This patch will enable setting controller model
when adding controller.

If no USB controller or usb model = none,
we could add a new one;
if had, disable 'create-finish' button.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:48:22 +08:00
Chen Hanxiao 7beb7db31d addhardware: move _change_config_helper from details
rename it as change_config_helper.
It will be used in the later patch.

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:47:19 +08:00
Chen Hanxiao b4a43fb6b7 preferences ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:33 +08:00
Chen Hanxiao ea4847961a host ui: add shortkey for tab page
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2014-06-16 11:43:09 +08:00