The patch added in the reverted commit was meant to fix the issue
https://github.com/bmwcarit/meta-ros/issues/291
In fact it enables CMake to look for libraries in a host system which
leads to errors when a path is tested for a library presence with the
help of CMake's find_library() command: e.g. a non-existing host
directory is tested for library presence and find_library() returns
successfully because the library exists in bitbake's sysroot; then the
directory is used by the linker, but the library doesn't exist in the
directory -> failure. In worse cases the host directory may actually exist
and contain the library, but of wrong architecture, format or
incompatible ABI making finding the root cause a difficult task.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
The fix for build type detection in librealsense's CMakeLists.txt
turned out to be non-functional in the official ROS build farm as
explained in https://github.com/IntelRealSense/librealsense/pull/404
Since this recipe is specific to meta-ros set the build type
explicitly to ROS to guaranty the catkin-related configs for
librealsense get created and installed properly.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
A patch for the config file is also necessary because the include directory
path was being hardcoded in the generated file, which caused problems for cross
compilation. That patch has already been applied on upstream but for a newer
version, so we're backporting it here.
Apparently, the Kinetic release for this package is supposed to work fine with
indigo distribution. That could be tried later, so that we can get rid of the
local patch.
Authors: JochiPochi <john.aleman@cyphyworks.com>
Gustavo Jose de Sousa <gustavo.sousa@intel.com>
As ar-track-alvar has been repaired, we can add this recipe back
to packagegroup-ros-world.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
ar_track_alvar 0.5.x only support opencv2, whereas meta-oe provides
opencv3. The ar_track_alvar kinectic versions 0.6.x also support
opencv3, as pointed out in the comment of commit e82747c4 [1].
Therefore, this commit updates ar-track-alvar to version 0.6.1
to resolve#397.
[1] e82747c42d.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
bitbake diagnostic-aggregrator failed due to missing build
dependencies with:
```
| -- Could not find the required component 'bondcpp'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
| CMake Error at /home/lukas/dev/openembedded.org/openembedded-core/build/tmp-glibc/sysroots/qemux86/opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
| Could not find a package configuration file provided by "bondcpp" with any
| of the following names:
|
| bondcppConfig.cmake
| bondcpp-config.cmake
|
| Add the installation prefix of "bondcpp" to CMAKE_PREFIX_PATH or set
| "bondcpp_DIR" to a directory containing one of the above files. If
| "bondcpp" provides a separate development package or SDK, be sure it has
| been installed.
| Call Stack (most recent call first):
| CMakeLists.txt:6 (find_package)
|
|
| -- Configuring incomplete, errors occurred!
```
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
Compiling rosconsole failed with:
```
[...]/ros_comm-1.11.20/tools/rosconsole/include/ros/console.h:121:14: error: 'vector' in namespace 'std' does not name a template type
typedef std::vector<TokenPtr> V_Token;
```
The console.h assumed that vector is included already by one of its
dependencies. This bold assumption has been uncovered by the update
of the boost library to version 1.62.0 [1, 2] in openembedded-core
repository.
Coincidently, this issue was also noticed by ROS users on Gentoo and
Arch Linux, which probably also use the latest boost library and gcc6,
and they opened pull requests on the indigo and kinetic branches [3, 4, 5]
with commits to address the issue. The patch in the kinetic branch has
been merged, the others to the indigo branch have been rejected as the
ros-comm maintainers intend to simply backport the patch from the
kinetic branch for the next release.
This commit applies the patch merged in the kinetic branch in our
recipe for the current indigo release version.
[1] http://cgit.openembedded.org/openembedded-core/commit/?id=c31030d87cd1741a4186d711325b8eab9c70b327
[2] http://cgit.openembedded.org/openembedded-core/commit/?id=42b4fa2f923244bc047874752d2e0381ff6f0a25
[3] https://github.com/ros/ros_comm/pull/911
[4] https://github.com/ros/ros_comm/pull/930
[5] https://github.com/ros/ros_comm/pull/939
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
meta-ros is supposed to be used for building a custom distribution
which isn't derived from any of the OSs known to the rospkg.os_detect
module.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
python-rosdep still depends on python-rosdistro in ROS Indigo.
This dependency needs to be dropped after updating the meta
layer to Kinetic.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
roswtf reports uninitialized /etc/ros structure and recommends
to fix the issue by running `rosdep init`. But rosdep throws an
exception when trying to import the missing rosdistro library.
The library is supposed to be dropped in kinetic, but it's still
needed in indigo which the layer is based on at the moment.
So, the patch adds the library to the layer.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
roswtf reports that
ROS_ROOT is invalid: ROS_ROOT [/opt/ros/indigo] must end in directory named 'ros'
Update README.md to change ROS_ROOT value to '/opt/ros'.
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
This commit removes the patch that has been accepted upstream
and has been included in the version 1.5.45.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
Due to the update to 1.8.0, the upstream-accepted patch is not
anymore needed to be applied.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
Compiling libflann 1.8.4 with gcc6 fails with:
```
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/i586-oe-linux/libflann/1.8.4-r0/flann-1.8.4-src/src/cpp/flann/algorithms/kdtree_index.h:666:39: error: call of overloaded 'abs(flann::KDTreeIndex<flann::KL_Divergence<double> >::ElementType)' is ambiguous
| ElementType span = abs(point[i]-leaf_point[i]);
| ~~~^~~~~~~~~~~~~~~~~~~~~~~~
```
This issue has been already addressed in the latest version 1.9.1,
hence the commit simply updates the recipe to the version 1.9.1,
which is available on github.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
Dmitry Rozhkov