Commit Graph

7669 Commits

Author SHA1 Message Date
Cole Robinson d9c6df951f installer: Remove cloudinit media after initial boot
We do this by faking an install phase whenever cloudinit media is
specified, which isn't really the right abstraction and will leak
into virt-install behavior (like doing 2 boots), but it's the simplest
fix for now

Fixes: #178

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 12:04:25 -05:00
Cole Robinson b132820244 devices: disk: Skip check_path_search for path=""
virt-manager can trigger this when ejecting cdrom media

Fixes: #180

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 12:04:25 -05:00
Martin Pitt 49a01b5482 virtinst: Fix TOCTOU in pool and volume enumeration
_fetch_all_pools_raw() and _fetch_vols_raw() have a race condition where
a pool/volume may disappear (from parallel libvirt operations) in
between enumerating and inspecting the objects.

_fetch_vols_raw() already expected that failure in the loop, but not for
the initial storagePoolLookupByName() call.

Also tighten the expected exception: This *should* crash on errors like
AttributeError or SystemExit, just not on dynamic libvirt errors. (Bare
exceptions are highly frowned upon in Python)

https://bugzilla.redhat.com/show_bug.cgi?id=1894359
2020-11-08 17:01:40 -05:00
emojifreak 04ad8df752 Added Debian's armv7l UEFI binary. Closes #174 2020-11-03 13:49:27 -05:00
Cole Robinson f4dc418e66 virtclone: Only print/log 'clone successful' if we actually clone
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:15:47 -05:00
Cole Robinson 8988572776 virtclone: Drop --print-xml special --auto-clone behavior
For unclear reasons we allowed --print-xml without --file or
--auto-clone, like is required for a traditional clone, which
can lead to some weird behavior.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:03:22 -05:00
Cole Robinson 1a1e4580c0 cloner: Explicitly reject 'network' disks we don't know how to clone
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:03:03 -05:00
Cole Robinson 2d4b85b5bf domain: use makedirs exist_ok=True
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 12:23:13 -05:00
Charles Arnold 9dc057e3e7 Add /usr/sbin to search path for non-root user
On a fresh install where no previous connection has been made a
non-root user starting virt-manager won't find the installed libvirtd
because the location is not in the user path.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Charles Arnold <carnold@suse.com>
2020-11-03 12:23:13 -05:00
Martin Pitt 7cb6a6062a virtinst: Fix TOCTOU race in user scratch dir creation
When starting many virt-install processes in parallel, some often crash
with

    ERROR    [Errno 17] File exists: '/home/kstest/.cache/virt-manager/boot'

Fix that by ignoring existing directories instead of explicitly testing
for existence.

The `exist_ok` parameter exists since Python 3.2, and the minimum
supported version is 3.4 now.
2020-11-03 11:52:46 -05:00
Cole Robinson d0650aa48f osdict: Handle possible conflicting os named 'generic'
It's not impossible osinfo-db adds a 'generic' OS of its own, in
which case we will start misbehaving. Rework the way we implement
our synthetic 'generic' OS internally, using a stub Libosinfo.Os()

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-10-21 18:49:11 -04:00
Cole Robinson b17914591a Prep for release 3.1.0 2020-09-30 18:06:22 -04:00
Cole Robinson 0643adfc49 uitests: Make sure we hit details perf page coverage
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 17:44:15 -04:00
Cole Robinson af63df9793 tests: Fix test_urls after pytest conversion
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 16:55:13 -04:00
Cole Robinson 3b96c32c49 po: Fix format error in cs.po
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 16:52:13 -04:00
Whired Planck 0c40a60c0c Translated using Weblate (Chinese (Simplified))
Currently translated at 98.9% (1398 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_CN/
2020-09-30 16:51:16 -04:00
Oğuz Ersen 7b4abfc238 Translated using Weblate (Turkish)
Currently translated at 71.8% (1015 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:16 -04:00
Weblate bc5f98e833 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-30 16:51:15 -04:00
Pino Toscano d8a69d41e4 Translated using Weblate (Italian)
Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-30 16:51:15 -04:00
Fabio Tomat a30ac4cbdd Translated using Weblate (Friulian)
Currently translated at 39.3% (556 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/fur/
2020-09-30 16:51:15 -04:00
Yuri Chornoivan f264994507 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-30 16:51:15 -04:00
Oğuz Ersen 7c7a24a0b6 Translated using Weblate (Turkish)
Currently translated at 56.2% (795 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:15 -04:00
Göran Uddeborg bada9d5750 Translated using Weblate (Swedish)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/

Translated using Weblate (Swedish)

Currently translated at 98.2% (1388 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-30 16:51:15 -04:00
Pavel Borecki f07dde41e7 Translated using Weblate (Czech)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-30 16:51:15 -04:00
Piotr Drąg 36f05e1099 Translated using Weblate (Polish)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-30 16:51:15 -04:00
Weblate 8aeec7c6bb Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-30 16:51:15 -04:00
Whired Planck 35754d8310 Translated using Weblate (Chinese (Simplified))
Currently translated at 98.6% (1399 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_CN/
2020-09-30 16:51:15 -04:00
Göran Uddeborg 4f7361c23a Translated using Weblate (Swedish)
Currently translated at 97.1% (1377 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-30 16:51:15 -04:00
Yuri Chornoivan 9e7de5eb7f Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1418 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-30 16:51:15 -04:00
Oğuz Ersen 737c3fcc7c Translated using Weblate (Turkish)
Currently translated at 56.4% (800 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/

Translated using Weblate (Turkish)

Currently translated at 54.7% (776 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:15 -04:00
Pino Toscano 4e726f2465 Translated using Weblate (Italian)
Currently translated at 98.5% (1397 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/

Translated using Weblate (Italian)

Currently translated at 98.4% (1396 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/

Translated using Weblate (Italian)

Currently translated at 97.8% (1387 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-30 16:51:15 -04:00
Pavel Borecki 30dc5121c9 Translated using Weblate (Czech)
Currently translated at 100.0% (1418 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-30 16:51:15 -04:00
Piotr Drąg 84c9542328 Translated using Weblate (Polish)
Currently translated at 100.0% (1418 of 1418 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-30 16:51:15 -04:00
Weblate a209ea704d Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-30 16:51:15 -04:00
Whired Planck 43e1a1ed2f Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (1410 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_CN/
2020-09-30 16:51:15 -04:00
Oğuz Ersen ef5a6b02a2 Translated using Weblate (Turkish)
Currently translated at 54.8% (774 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:15 -04:00
Göran Uddeborg 08b3d825a6 Translated using Weblate (Swedish)
Currently translated at 97.1% (1370 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-30 16:51:15 -04:00
Weblate 1092019606 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-30 16:51:15 -04:00
Yuri Chornoivan 56129a46ef Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1410 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-30 16:51:15 -04:00
Göran Uddeborg 26eb732e59 Translated using Weblate (Swedish)
Currently translated at 91.3% (1288 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-30 16:51:15 -04:00
Pino Toscano 34512fefce Translated using Weblate (Italian)
Currently translated at 98.2% (1386 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-30 16:51:15 -04:00
Cole Robinson 96996fad30 Added translation using Weblate (Kabyle) 2020-09-30 16:51:15 -04:00
Piotr Drąg f938c3ba27 Translated using Weblate (Polish)
Currently translated at 100.0% (1410 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-30 16:51:15 -04:00
scootergrisen 9df7a66dfc Translated using Weblate (Danish)
Currently translated at 15.3% (216 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/

Translated using Weblate (Danish)

Currently translated at 15.1% (214 of 1410 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/
2020-09-30 16:51:15 -04:00
Github Actions b7b9907b2d Refresh translation .pot template 2020-09-30 16:51:15 -04:00
Cole Robinson 129865aea0 mediacombo: Clear text entry when New VM is launched
We were leaving the ISO field populated with whatever the old value
was. This is likely useful in some cases but it's consistent with
how we handle fields in the rest of the wizard, and has some weird
interaction with OS detection

Fixes: #159

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 10:35:21 -04:00
Cole Robinson f7bd274a55 domcaps: Fix error if enum not found
https://bugzilla.redhat.com/show_bug.cgi?id=1883008

In the example above this is because the VM XML has an invalid machine
type, so domcaps fetching entirely fails, and a get_enum() call
then fails. But this could happen if using virt-manager against an
older libvirt that doesn't advertise the enum

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-28 13:44:34 -04:00
Cole Robinson 9c13d2f878 Remove use of problematic terminology
Following kernel recommendation here:
https://lkml.org/lkml/2020/7/4/229

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-23 14:33:17 -04:00
Cole Robinson 12fe58cd91 uitests: Use drag() method again for window cleanup tests
delete and createvm tests launch a dialog which obstructs the
manager UI. The location can be kinda random, and it might obstruct
selecting the connection in the manager window. Go back to using
the drag() window pattern to make this more deterministic

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-22 11:28:21 -04:00
Cole Robinson 9a5ab50b51 gfxdetails: Use a single 'changed' signal
And absord device building from addhardware. This moves all the
knowledge to gfxdetails, which saves sprinkling it around in other
places

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-21 22:11:17 -04:00