rospkg is necessary to generate dreconf files. dynamic-reconfigure was not
providing proper build-time depencency to packages that use it.
This patch series adds ${PYTHON_PN}-roskpg to DEPENDS of dynamic-reconfigure.bb
and removes unnecessary reference to it in all recipes that are using dynamic-reconfigure.
There were a fix for theora-image-transport with missing libvorbis as well.
[modified commit message header.]
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Due to the update, this commit drops the two previous patches that
are now included in the upstream development. For depth-image-proc,
the commit provides a patch to properly find Eigen. For image-proc,
the commit adjusts the dependencies and tunes its formatting.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
With these improved build dependencies, the image-view recipe
configures successfully. However, compiling fails due to not
finding the gtk headers.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
By default meta-ros uses python2. In case you want to get
python3-compatible builds add the following line to your local.conf:
ROS_USE_PYTHON3 = "yes"
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
The description is not indented after line breaks. All other
information, i.e., the dependencies and SRCURI, are indented with
four spaces after line breaks. Shell scripts are indented with
multiples of four spaces.
In recipes-ros, I located and checked for tabulators and spacing
with these bash commands:
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [^ ]+' . --exclude *.patch -R
egrep '^ [ ]+[^ ]+' . --exclude *.patch -R
While going through the recipes and manually improving the layout,
I also adjusted the descriptions to use maximal 100 characters
per line.
Executing 'bitbake packagegroup-ros-world' showed the warning:
WARNING: QA Issue: image-rotate rdepends on nodelet but its not a build dependency? [build-deps]
On a clean build, 'bitbake image-rotate' failed with:
| Could not find a package configuration file provided by "nodelet" with any
| of the following names:
|
| nodeletConfig.cmake
| nodelet-config.cmake
|
Hence, this commit adds the missing dependency on nodelet.
Lukas Bulwahn